Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize keys in "requires" object #199

Merged
merged 1 commit into from
Jan 21, 2016
Merged

Normalize keys in "requires" object #199

merged 1 commit into from
Jan 21, 2016

Conversation

sgress454
Copy link
Contributor

It's clear from the existing tests that the different keys were intentional, but there are a couple of good reasons to normalize them:

  1. It makes it a lot easier to automate the process of pre-loading an engine into the requires object (you don't have to keep track of the alternate key names)
  2. The current scheme is not consistent--Liquid loads the "tinyliquid" engine but uses "requires.liquid", and Hogan loads the "hogan.js" engine but uses "requires.hogan"

BridgeAR added a commit that referenced this pull request Jan 21, 2016
Normalize keys in "requires" object
@BridgeAR BridgeAR merged commit 7d45021 into tj:master Jan 21, 2016
@BridgeAR
Copy link
Collaborator

Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants